Icon picker: move catalogue to LocalAppData, grow default to 100 glyphs#42
Merged
Merged
Conversation
The catalogue now lives at %LOCALAPPDATA%\Snipdeck\icon-catalogue.json (renamed from appsettings.json) so user edits survive Velopack updates. It's seeded on first run from a default embedded in the app — delete the file to restore it — and the embedded default also serves as the fallback when the user copy is missing or malformed. Read fresh on each open. The default set grows from 50 to 100 glyphs, all code points grounded against the official Segoe Fluent Icons list, and now covers billing, customer, contract, invoice, person, marketplace, orders, preview, price list, renewal, report and transfer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the icon picker (PR #40), addressing two requests: make the catalogue durable across updates, and broaden the default set.
What & why
%LOCALAPPDATA%\Snipdeck\icon-catalogue.json(renamed fromappsettings.json). Previously it shipped beside the executable, where a Velopack update would overwrite user edits. Now it lives alongside the rest of the app config, so edits survive updates.How
IconCatalogueFileName/IconCatalogueFilePathonDefaultPaths, surfaced throughIPathProvider(and its implementers + the test fake), wired inBootstrap.GlyphCatalogueProvidernow takes the LocalAppData path, seeds-if-missing (write-then-rename), reads the user file, and falls back to the embedded resource. The catalogue JSON is anEmbeddedResourcewith a pinnedLogicalName.Testing
GlyphPickerViewModelcoverage still applies).🤖 Generated with Claude Code